Repository navigation
netrcによる認証を廃止します - #795
Merged
Merged
netrcによる認証を廃止します#795
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the change removing .netrc authentication fallback.
No open issues 🎉
What changed in this PR
Annofab APIクライアントの.netrcによる認証情報の読み込みを廃止し、引数なしのbuild()では環境変数のみを参照するように変更します。
変更内容:
build_from_netrc()と公開エクスポートを削除。.netrcへフォールバックしないことを確認するテストを追加し、環境変数の操作をmonkeypatchに統一。- 認証手順を更新し、PATの利用を推奨。
| File | Description |
|---|---|
| tests/test_build.py | .netrcを無視する動作を検証し、テスト間の環境変数への影響を防止。 |
| README.md | .netrcの説明を削除し、環境変数の優先順位とPAT推奨を明記。 |
| README_for_developer.md | テスト用の認証設定をANNOFAB_PATに変更。 |
| docs/user_guide/basic_usage.rst | 古い.netrc関連ログ例を削除し、変数名の誤記を修正。 |
| annofabapi/resource.py | .netrc読み込み処理を削除し、環境変数への処理委譲を簡素化。 |
| annofabapi/__init__.py | build_from_netrcの公開エクスポートを削除。 |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PAT 認証へ利用を誘導し、認証情報の取得方法をシンプルにするためnetrcによる認証を廃止します。