Repository navigation
README.mdからSimple Annotationの属性制約に関する説明を削除し、AttributeRestrictionValidatorクラスのドキュメントを更新。テストケースの名称を変更し、読み取り専用属性の検証を追加。 - #799
Merged
Merged
Conversation
…atorクラスのドキュメントを更新。テストケースの名称を変更し、読み取り専用属性の検証を追加。
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for this change.
No open issues 🎉
What changed in this PR
Simple Annotationの属性制約検証で、読取専用属性も評価対象に変更するPRです。CanInputを評価対象外とする動作は維持しています。
変更内容:
- 読取専用属性の制約を除外する処理を削除し、クラスの説明を更新。
CanInputの除外テストと読取専用属性の検証テストを分離し、属性値ごとの判定を確認。- READMEからSimple Annotation ZIPの属性制約検証に関する説明を削除。
| File | Description |
|---|---|
tests/util/test_attribute_restriction_validation.py |
テスト名を変更し、読取専用属性の未設定・空文字・非空文字の検証を追加。 |
README.md |
属性制約検証の説明と使用例を削除。 |
annofabapi/util/attribute_restriction_validation.py |
読取専用属性を制約の評価対象に変更し、ドキュメントを更新。 |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.