Optimize native exact-tree materialization (replacement) - #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successor to the preserved predecessor #28. This replacement branch starts at current
origin/main(f29da812) and imports only its RTCGit performance, timeout, fixture, documentation, and focused-test changes; the predecessor branch and PR remain untouched.The change batches committed blob metadata/content, reads numstats once, and bounds patch concurrency at four while retaining exact revision identity, shell-free
/usr/bin/git, option termination, hostile filename bytes, cancellation checks, error mapping, and existing file/patch/total/time caps. It also uses pinned-Git-compatible-zrequest framing and newline response parsing.The first two unsigned-validation attempts reached the workflow's 15-minute timeout while
RTCIngestTestswas running. Four concurrent patches had placed blocking pipe reads andwaitpidcalls on Swift's cooperative executor, which can starve on lower-core CI hosts. The runner now performs those bounded blocking calls on an overcommitting dispatch queue; there was no workflow concurrency rule or superseding cancellation.Validation:
npm run checkpassed.scripts/native-check.shbuilt the native graph and passed checks through the known unrelatedRTCIngestTestsabort:RTCIPC.IPCTransportError.socketPathTooLongfrom this long isolated worktree. Remaining native executables and Xcode project generation passed when run directly; the branch does not broaden into RTCIngest/RTCIPC ownership.XCTest targets, the full-Xcode build/UI tests, signing, notarization, clean-install, and release evidence remain unclaimed on this Command Line Tools host.