Fix mounted native diff canvas retention - #35
Open
kvkenyon wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- retain the ReviewCanvasController through the mounted workspace bridge coordinator\n- add a mounted SwiftUI/AppKit regression for populated canvas rows, line selection, and Comment enablement\n- record diff-ready and first-interaction characterization timings\n\n## Validation\n- swift run --package-path native RTCReviewWorkspaceFeatureTests\n- swift run --package-path native RTCDiffCanvasTests\n- scripts/native-check.sh (XCTest/full-Xcode gates explicitly unavailable under CLT)\n- npm run check\n\nThe regression failed before the fix because the mounted collection view's delegate/controller had deallocated; it passes with a 0.150s diff-ready and 0.000069s first-interaction measurement.