Repository navigation
Keep the text readable when the pane is too narrow for the comment column - #92
Merged
Merged
Conversation
The column always took its full 320px, so on a narrow pane the text was squeezed to whatever was left: a sliver one character wide below about 400px. The anchors moved thousands of pixels down with it, so their cards went off-screen too (#83). Stop the text at --dc-min-text-width (15rem) in Live Preview and Reading view. On a pane too narrow for both, the column overlaps the right edge of the text instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #83
The margin column always took its full 320px, so on a narrow note pane the text got whatever was left. Below about 600px it shrank to a sliver, one character wide at a 406px pane. The anchors moved thousands of pixels down with it, so their cards went off-screen.
--dc-min-text-width(15rem), in Live Preview and Reading view.Testing
npm run checkpasses. Three new style tests, failing onmain: both text-width rules use the minimum, and the variable is defined.Obsidian, Live Preview, both sidebars open, window narrowed in steps:
Reading view measures the same at 852, 606 and 406px.
A fresh-agent regression review found nothing.
Not reproduced as reported: the issue has the cards vanishing below line width + 320px (about 1020px here). On macOS with Obsidian 1.14.1 they still showed at 852px, and only went off-screen once the text was a few characters wide. That's why this says "Refs", not "Fixes".