fix: address critical security vulnerabilities#1
Open
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Open
fix: address critical security vulnerabilities#1devin-ai-integration[bot] wants to merge 1 commit intomainfrom
devin-ai-integration[bot] wants to merge 1 commit intomainfrom
Conversation
- Validate X-CacheTest-Error header value in fastly-cache-test.ts to prevent arbitrary HTTP status codes (must be 100-599) - Restrict /_req-headers endpoint to development environment only to prevent leaking sensitive request headers in production/staging - Tighten /_500 trigger-error guard to only allow in development and test environments, blocking staging deployments - Run npm audit fix to patch vulnerable dependencies (axios SSRF, liquidjs file read, lodash prototype pollution, etc.) Co-Authored-By: laloesparza458 <laloesparza458@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Security audit of the codebase identified several issues: exposed debug endpoints accessible outside development, unvalidated user-controlled input used in HTTP responses, and known-vulnerable transitive dependencies.
What's being changed (if available, include any code snippets, screenshots, or gifs):
Three targeted code fixes + dependency patching:
src/frame/middleware/fastly-cache-test.ts— TheX-CacheTest-Errorheader value was passed directly tores.status(parseInt(...))with no validation. Malformed values (NaN, negative, >599) could cause unexpected Express behavior. Now validates the parsed integer is a valid HTTP status code (100–599) and returns 400 otherwise.src/frame/middleware/req-headers.ts— The/_req-headersendpoint unconditionally returned all request headers (including cookies, auth tokens, internal proxy headers) as JSON in every environment. Now gated toNODE_ENV === 'development'only; returns 404 elsewhere.src/observability/middleware/trigger-error.ts— The/_500endpoint was guarded byNODE_ENV === 'production' && MODA_PROD_SERVICE_ENV === 'true', meaning it remained accessible in staging. Changed to an allowlist: only fires indevelopmentortestenvironments.package-lock.json—npm audit fixpatched vulnerable transitive dependencies including ajv (ReDoS), vite (path traversal / arbitrary file read), and proxy-from-env.trigger-error.tsallowlist change: confirm no non-dev/test environment legitimately needs this endpoint for error-handling validation.req-headers.tsroute is still registered in the middleware stack but returns 404 in non-dev. Confirm this is acceptable vs. removing the route entirely.package-lock.jsonchanges are fromnpm audit fix— transitive-only updates, but worth a sanity check.Check off the following:
Link to Devin session: https://app.devin.ai/sessions/30070cf782bd4b4aae917569b573e6a7
Requested by: @lalo458