Closed
Conversation
emyfops
reviewed
May 27, 2025
common/src/main/kotlin/com/lambda/module/modules/movement/LevitationTweaks.kt
Outdated
Show resolved
Hide resolved
| REMOVE("Remove"), UNCP("NCP New") | ||
| } | ||
|
|
||
| private var capturedEffect: StatusEffectInstance? = null |
Collaborator
There was a problem hiding this comment.
This should be a lazy updatable that updates the effect on demand to avoid mutating states, see the utils
|
|
||
| private var capturedEffect: StatusEffectInstance? = null | ||
| private var wearOffTime: LocalDateTime? = null | ||
| private var canMove = false |
Collaborator
There was a problem hiding this comment.
Maybe this could be a getter
927f92d to
cc53490
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds LevitationTweaks, with a
REMOVEandUNCPmode.UNCPmode is designed to by default fully abuse poor checks in Updated-NoCheatPlus and might also work in legacy NCP (not tested).The
REMOVEmode has a unique feature that reapplies the effect when the module is disabled before the (server-sided) levitation effect runs out, as most clients just remove the effect which causes desynchronization. It is currently implemented using a time comparison, but on servers with poor TPS this may cause issues so this needs to be looked atCode is functional but not yet refactored
Showcase:
https://youtu.be/Vi9CGH3xkBU