Skip to content

fix: make SFD-387 allowlist probe man-independent #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaruesink merged 1 commit into from
Sep 28, 2026
Merged

fix: make SFD-387 allowlist probe man-independent #60

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions scripts/lib/git-state.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,14 @@ test("git subcommands the allowlist covers are spelled the way git accepts them"
if (subcommand === "lfs" || subcommand === "ls-remote") {
continue; // needs an external tool / network
}
const probe = git(repo, [subcommand, "--help"]);
expect(`${subcommand}:${probe.status === 0}`).toBe(`${subcommand}:true`);
// `--help` delegates to the platform man viewer, which is absent in some
// otherwise-valid consumer environments. `-h` prints built-in usage.
const probe = git(repo, [subcommand, "-h"]);
const printsGitUsage = /usage: git /.test(
`${probe.stdout}\n${probe.stderr}`,
);
expect(
`${subcommand}:${probe.status === 0 || (probe.status === 129 && printsGitUsage)}`,
).toBe(`${subcommand}:true`);
}
});
Loading