Extra tests for move and autoderef#15
Open
ijackson wants to merge 2 commits intolambda-fairy:mainfrom
Open
Conversation
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
Signed-off-by: Ian Jackson <ijackson@chiark.greenend.org.uk>
lambda-fairy
requested changes
Apr 17, 2021
Owner
lambda-fairy
left a comment
There was a problem hiding this comment.
Thanks for the tests!
I made a few simplifications which should help readability.
|
|
||
| #[test] | ||
| fn magic_deref() { | ||
| fn f(y: &'static str) -> (&'static str, bool) { |
Owner
There was a problem hiding this comment.
This can be simplified:
#[test]
fn magic_deref() {
struct Wrapped<T>(T);
let s = "hello";
if_chain! {
then { Wrapped(s) }
else { Wrapped(&s) }
};
}|
|
||
| #[test] | ||
| fn no_move() { | ||
| struct NoCopy; |
Owner
There was a problem hiding this comment.
This as well:
#[test]
fn no_move() {
struct NoCopy;
let x = NoCopy;
if_chain! {
then { drop(x); }
else { drop(x); }
}
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My now-closed-by-me MR #14 seemed simple and passed the in-tree
if_chaintests but produced a number of regressions in projects of my own. That seems suboptimal. I have distilled the failure cases into these new tests, which pass on currentif_chainand break with my #14.