test: cover allowedAxioms via lakefile leanOptions in consumer#2
Merged
Conversation
Allow-list Consumer.benign and Consumer.alsoBenign project-wide via leanOptions in the consumer lakefile; assert they stay silent while evil is still flagged. Verified load-bearing: without the option all six warnings fire, and lean rejects the -D name when the plugin is not loaded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
linter.axiomGuard.allowedAxiomsoption through the lakefile configuration path of the plugin-consumer package (previously only covered per-file viaset_option ... inin the import-based fixtures).test/consumer/lakefile.leanallow-listsConsumer.benignandConsumer.alsoBenignproject-wide:axiom alsoBenignplususes_benign/uses_benign_alsotheorems in the consumer, value string exercises both separators (comma and space).test/run.shgains two assertions: no guard warning may mention the allow-listed axioms (neither at theaxiomdeclaration sites nor at use sites), andevilmust still be flagged.Verification
test/run.sh: 10 passed, 0 failed.leanOptionsline removed, all six warnings fire (evil/benign/alsoBenignat declaration and use sites) — the option is load-bearing.-Dflag only validates becauselake buildpasses--plugin(registering the option) alongside it; a barelake env lean -Dlinter.axiomGuard.allowedAxioms=...is rejected with "unknown configuration option". Documented in the lakefile comment.