ci: fix rust-cache target path and drop doctest step#160
Merged
Conversation
The rust-cache `workspaces` pointed at `crates/lance-context-core` and `python`, but this is a single root workspace whose build output lives in `./target`. Those subdirs have no target/, so the cache never captured the compiled dependencies and every run rebuilt everything from scratch (including the rocksdb C++ library). Point it at `.` so the real target dir is cached. Also drop the `Run doc tests` step: the core crate has a single doctest (~7s locally) but the step re-links the whole rocksdb-bearing crate, costing ~7min per run for near-zero coverage. Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The Rust Tests job has been consistently slow (~23min). Two unrelated PRs (#151, #159) showed the same pattern, which pointed to a CI config issue rather than anything a specific change introduced.
Root cause
workspacespointed atcrates/lance-context-coreandpython, but this is a single root workspace whose build output lives in./target. Those subdirs have notarget/, so the cache was always empty and every run rebuilt all dependencies from scratch — including the rocksdb C++ library compiled from source.lance-context-corehas a single doctest (~7s locally), but the step re-links the entire rocksdb-bearing crate, costing ~6.85min per run.Changes
workspaces: "."— cache the actual./target.Run doc testsstep.Expected impact
🤖 Generated with Claude Code