feat: api changes for materialized views and udtfs#344
Merged
Conversation
Contributor
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
Make the source_query description backend-agnostic — it is an opaque, client-defined serialized query that the namespace server stores without interpreting (no longer names the geneva query builder). Also trims the CreateMaterializedView operation description and rewords the kind enum. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jackye1995
reviewed
May 19, 2026
Mirror the pattern used by refresh_materialized_view: a base-class method that raises UnsupportedOperationError, so backends opting in just override it. Without this, generated clients can call the CreateMaterializedView REST operation but the high-level LanceNamespace surface has no entry point for it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
jackye1995
reviewed
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API changes to support creating materialized views, UDTF views, and refresh