Skip to content

feat: support zonemap index segments#6593

Open
beinan wants to merge 4 commits intolance-format:mainfrom
beinan:user/beinan/zonemap-index-segments
Open

feat: support zonemap index segments#6593
beinan wants to merge 4 commits intolance-format:mainfrom
beinan:user/beinan/zonemap-index-segments

Conversation

@beinan
Copy link
Copy Markdown
Contributor

@beinan beinan commented Apr 22, 2026

Summary

  • allow zonemap to build uncommitted segments over explicit fragment subsets
  • add a logical multi-segment zonemap index that unions segment search and fragment coverage
  • route name-based scalar zonemap loading through the logical multi-segment path in query execution

Context

This keeps the public index type as zonemap and follows the index-segment direction discussed in the zonemap vote, instead of introducing a separate public partitioned zonemap type.

Testing

  • cargo test -p lance-index test_null_zonemap_index --lib
  • cargo test -p lance test_open_named_scalar_index_uses_all_zonemap_segments --lib
  • cargo test -p lance test_like_prefix_with_zone_map --lib

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This pull request is from a fork — automated review is disabled. A repository maintainer can comment @claude review to run a one-time review.

@github-actions github-actions Bot added the enhancement New feature or request label Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 76.45503% with 89 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance/src/index/scalar_logical.rs 69.62% 74 Missing and 8 partials ⚠️
rust/lance/src/dataset/scanner.rs 96.15% 2 Missing and 2 partials ⚠️
rust/lance/src/io/exec/scalar_index.rs 25.00% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant