Repository navigation
deps: update dependencies - #13
Merged
Merged
Conversation
westonpace
approved these changes
Oct 2, 2026
westonpace
left a comment
westonpace
left a comment
Contributor
There was a problem hiding this comment.
Just one minor question
|
|
||
| /* Interop Constraints */ | ||
| // "isolatedModules": true, /* Ensure that each file can be safely transpiled without relying on other imports. */ | ||
| "isolatedModules": true, /* Ensure that each file can be safely transpiled without relying on other imports. */ |
Contributor
There was a problem hiding this comment.
Is this no longer the default? Why did this one change to being explicitly specified?
Contributor
Author
There was a problem hiding this comment.
oh sorry I didn't mention this, we updated ts-jest from 29.2.5 which didn't care about this, to 29.4.14 (current) - as of 29.3, it raises a warning if isolatedModules is false. (plus, isolatedModules: true makes it build a little faster)
otherwise it just checks for a couple more type-check errors (re-exporting types, const enum emit changes), doesn't change the output at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking about using this in enterprise, so I'm trying to resurrect it a bit. This PR does the following: