feat(vertex_ai): add Gemini 3.5 Flash model support#3167
Conversation
Adds the `gemini-3.5-flash` model definition under vertex_ai, mirroring the parameter style of the existing Gemini 3 family (thinking_level, include_thoughts, media_resolution, grounding, url_context, code_execution, json_schema). Registers the model in `GLOBAL_ONLY_MODELS_DEFAULT` and bumps the plugin manifest to 0.0.54. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request introduces the gemini-3.5-flash model to the Vertex AI provider. The changes include a new configuration file defining the model's features, parameters—such as temperature, thinking level, and media resolution—and pricing details. The model has also been added to the supported models list in llm.py, and the manifest version was incremented. I have no feedback to provide as there were no review comments to evaluate.
There was a problem hiding this comment.
Code Review
This pull request adds support for the Gemini 3.5 Flash model by adding a new configuration file and updating the model list. Feedback suggests that pricing values should be numeric rather than strings for better system integration. Additionally, the reviewer recommended reducing the maximum output tokens and reviewing the pricing figures, which seem high compared to typical Flash model specifications.
There was a problem hiding this comment.
Code Review
This pull request adds support for the gemini-3.5-flash model to the Vertex AI provider, updates the manifest version, and registers the new model. The reviewer suggested verifying the pricing rates due to their high values, adjusting the max_output_tokens to 8,192 to prevent API errors, and using numeric types for pricing fields in the YAML configuration.
|
Nice addition! A few observations from the automated review:
|
Thanks for the review. I checked all three against the docs and the existing vertex_ai files: Pricing format — all current vertex_ai Gemini YAMLs use quoted strings (input: '0.50', etc.). I matched that convention; bare floats would make this file the inconsistent one. |
Adds the
gemini-3.5-flashmodel definition under vertex_ai, mirroring the parameter style of the existing Gemini 3 family (thinking_level, include_thoughts, media_resolution, grounding, url_context, code_execution, json_schema). Registers the model inGLOBAL_ONLY_MODELS_DEFAULTand bumps the plugin manifest to 0.0.54.Summary
Change Type
Screenshots / Videos
LLM Plugin Checklist
Areas affected by this change (check all that apply)
Version
versioninmanifest.yaml(not the one undermeta)dify_plugin>=0.3.0,<0.6.0is declared inpyproject.tomland locked inuv.lock(or kept inrequirements.txtfor legacy plugins withoutuv.lock) — SDK docsTesting