fix: migrate model type enum construction#36550
Draft
WH-2099 wants to merge 1 commit into
Draft
Conversation
Contributor
Pyrefly Type Coverage
|
asukaminato0721
approved these changes
May 23, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #36550 +/- ##
==========================================
- Coverage 86.11% 86.11% -0.01%
==========================================
Files 4483 4483
Lines 214917 214917
Branches 39897 39897
==========================================
- Hits 185068 185066 -2
- Misses 26457 26459 +2
Partials 3392 3392
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ModelType.value_of(...)usages with directModelType(...)constructionMerge note
This PR is intentionally blocked until langgenius/graphon#157 is merged, released, and the Dify Graphon dependency is upgraded to that release. Before that dependency upgrade,
ModelType(...)may not accept legacy provider model type aliases such asembeddings,text-generation, andreranking.Validation
uv run --project api ruff format --check api/core/provider_manager.py api/services/model_load_balancing_service.py api/services/model_provider_service.pyuv run --project api ruff check api/core/provider_manager.py api/services/model_load_balancing_service.py api/services/model_provider_service.pyCloses #36549