Skip to content

refactor(web): remove prompt generator React.FC - #40330

Closed
lyzno1 wants to merge 1 commit into
codex/refactor-prompt-generator-iconfrom
codex/refactor-prompt-generator-component
Closed

refactor(web): remove prompt generator React.FC#40330
lyzno1 wants to merge 1 commit into
codex/refactor-prompt-generator-iconfrom
codex/refactor-prompt-generator-component

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • type PromptGeneratorBtn props directly on the function parameter
  • remove the FC type import and annotation
  • preserve the component API, JSX, state transition, and runtime behavior

Dependency

This cleanup is stacked on #40329 only because it edits the same component after the icon conversion. It has no accessibility or runtime dependency and remains a separate review layer.

Visual regression review

This is a type-only refactor. The emitted JSX, classes, visible content, interaction states, modal behavior, and accessibility tree are unchanged. A visual difference would be a regression.

Validation

  • focused Vitest: 1/1 passed
  • standalone accessibility lint: 0 findings
  • focused format/lint/type check: 0 findings
  • full pnpm check: 0 errors, 2058 existing warnings
  • git diff --check: passed

Rollback

Revert this PR alone to restore React.FC without affecting either lower stack layer.

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@lyzno1

lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Closing during the accessibility stack audit. This layer only changes component typing or icon implementation, adds no user-visible accessibility contract, and carries independent visual/review risk. It can be reconsidered later as a separate cleanup, not as an a11y dependency.

@lyzno1 lyzno1 closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant