fix(web): expose chat variable tips state - #40334
Open
lyzno1 wants to merge 1 commit into
Open
Conversation
lyzno1
force-pushed
the
codex/a11y-chat-variable-panel-tips
branch
from
August 9, 2026 14:31
348cb97 to
885ae49
Compare
lyzno1
force-pushed
the
codex/a11y-chat-variable-panel-tips
branch
from
August 9, 2026 15:18
885ae49 to
e8c95f2
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/a11y-chat-variable-panel-close #40334 +/- ##
=====================================================================
Coverage 86.42% 86.43%
=====================================================================
Files 5107 5107
Lines 290741 290741
Branches 57924 57924
=====================================================================
+ Hits 251287 251290 +3
+ Misses 34513 34510 -3
Partials 4941 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
marked this pull request as ready for review
August 9, 2026 15:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TIPSaria-expandedDependency
Stacked on #40333 because both layers update the same owner test and header. This layer does not depend on the close action at runtime and remains a single semantic contract.
Validation
pnpm --dir web exec vp test run app/components/workflow/panel/chat-variable-panel/__tests__/index.spec.tsx— 4/4 passedpnpm --dir web lint:a11y 'app/components/workflow/panel/chat-variable-panel/index.tsx'— passedpnpm check— 0 errors / 2059 existing warningsgit diff --check— passedVisual regression review
Expected visual delta: none.
Please verify:
Only ARIA attributes were added; the existing
ActionButtonState.Activeremains the sole visual-state owner.Rollback
Revert this PR without reverting #40333. The close action remains valid independently.