refactor(web): remove assigner panel React.FC - #40339
Closed
lyzno1 wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## codex/refactor-assigner-add-icon #40339 +/- ##
===================================================================
Coverage ? 86.43%
===================================================================
Files ? 5107
Lines ? 290741
Branches ? 57924
===================================================================
Hits ? 251291
Misses ? 34509
Partials ? 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
Closing during the accessibility stack audit. This layer only changes component typing or icon implementation, adds no user-visible accessibility contract, and carries independent visual/review risk. It can be reconsidered later as a separate cleanup, not as an a11y dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React.FCmemodirectly instead of retaining the React namespaceBoundary
This PR is deliberately isolated from the semantic fix and CSS icon conversion. It changes only the component declaration and import shape.
Validation
pnpm --dir web exec vp test run app/components/workflow/nodes/assigner/__tests__/panel.spec.tsx— 1 passedpnpm --dir web lint:a11y app/components/workflow/nodes/assigner/panel.tsx— passedpnpm check— 0 errors, 2058 warningsgit diff --check— passedVisual regression review
The runtime output should be byte-for-byte equivalent at the component boundary. Any DOM, interaction, layout, or visual difference is a regression.
Stack
Depends on #40338. Final PR in stack #40340.