Skip to content

refactor(web): use css icons for chat settings - #40342

Closed
lyzno1 wants to merge 2 commits into
codex/a11y-chat-settings-triggersfrom
codex/refactor-chat-settings-icons
Closed

refactor(web): use css icons for chat settings#40342
lyzno1 wants to merge 2 commits into
codex/a11y-chat-settings-triggersfrom
codex/refactor-chat-settings-icons

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the two decorative SVG components in the chat-with-history settings popover with matching CSS icons
  • preserve the trigger glyph at 18px and the panel glyph at 24px
  • remove the now-unused icon imports

Boundary

This PR contains only visual-resource substitutions. The accessible name and state contract remain owned by #40341; the embedded chatbot already uses the matching CSS trigger icon.

Validation

  • focused lint — both icon-component warnings removed
  • the two focused popover suites — 4 passed
  • standalone a11y lint on both production components — passed
  • pnpm check — 0 errors, 2057 warnings (exactly two fewer)
  • git diff --check — passed

Visual regression review

Compare the chat-settings glyph and filled message glyph shape, 18px/24px bounds, current-color rendering, alignment, shrink behavior, button box, panel spacing, hover/open states, and light/dark themes. No visual difference is intended; any mismatch is a regression.

Stack

Depends on #40341. Final PR in stack #40343.

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@lyzno1
lyzno1 force-pushed the codex/a11y-chat-settings-triggers branch from 393258d to 56bfe8b Compare August 9, 2026 13:47
@lyzno1

lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member Author

Closing during the accessibility stack audit. This layer only changes component typing or icon implementation, adds no user-visible accessibility contract, and carries independent visual/review risk. It can be reconsidered later as a separate cleanup, not as an a11y dependency.

@lyzno1 lyzno1 closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant