Skip to content

fix(web): name chat history controls - #40344

Merged
lyzno1 merged 1 commit into
mainfrom
codex/a11y-chat-history-controls
Aug 10, 2026
Merged

fix(web): name chat history controls#40344
lyzno1 merged 1 commit into
mainfrom
codex/a11y-chat-history-controls

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • name chat-history actions for sidebar expansion, new chat, reset, expand, and collapse
  • hide decorative header glyphs
  • replace positional button queries with role-and-name interactions

Review boundary

Callbacks, disabled logic, tooltips, sidebar transitions, visibility lifecycle, elements, classes, and layout are unchanged.

Verification

  • header and sidebar suites: 78/78 passed
  • standalone a11y lint: 0 diagnostics
  • full static check: 0 errors
  • diff check: passed

Visual regression and dependency

Production changes are ARIA-only, so normal pixels remain identical. This is an independent root layer; the former React typing cleanup is closed.

@lyzno1 lyzno1 changed the title codex/a11y chat history controls fix(web): name chat history controls Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.43%. Comparing base (7522ae1) to head (ca9e21d).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40344      +/-   ##
==========================================
- Coverage   86.47%   86.43%   -0.04%     
==========================================
  Files        5264     5107     -157     
  Lines      294867   290747    -4120     
  Branches    59029    57924    -1105     
==========================================
- Hits       254976   251299    -3677     
+ Misses      34950    34507     -443     
  Partials     4941     4941              
Flag Coverage Δ
cli ?
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@lyzno1
lyzno1 marked this pull request as ready for review August 9, 2026 15:47
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 9, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 10, 2026
@lyzno1
lyzno1 added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit c29425c Aug 10, 2026
59 of 70 checks passed
@lyzno1
lyzno1 deleted the codex/a11y-chat-history-controls branch August 10, 2026 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants