Skip to content

refactor(web): rely on QR panel containment - #40352

Merged
lyzno1 merged 3 commits into
mainfrom
codex/refactor-qrcode-panel-boundary
Aug 10, 2026
Merged

refactor(web): rely on QR panel containment#40352
lyzno1 merged 3 commits into
mainfrom
codex/refactor-qrcode-panel-boundary

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • remove the QR panel's redundant click-stopping handler
  • rely on the existing document listener and ref.contains boundary
  • remove the two suppressions required by the old non-interactive click handler
  • prove that panel clicks bubble to business ancestors without closing the panel

Behavior contract

Outside clicks close the panel. Panel, canvas, scan-text, and download interactions remain inside the ref and keep it open. Internal clicks are no longer swallowed.

Visual regression review

There is no rendered-tree, class, focus, positioning, size, spacing, canvas, typography, tooltip, or light/dark change.

Verification

  • owner suite: 8/8 passed
  • new regression test fails while the redundant stopPropagation handler exists
  • standalone a11y lint: 0 diagnostics
  • full pnpm check: 0 errors
  • suppression delta: -2
  • diff check: passed

Dependency and rollback

Independent root layer. Revert it to restore the handler and its two suppressions together.

@lyzno1 lyzno1 changed the title codex/refactor qrcode panel boundary refactor(web): rely on QR panel containment Aug 9, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.43%. Comparing base (7522ae1) to head (f16de5e).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40352      +/-   ##
==========================================
- Coverage   86.47%   86.43%   -0.05%     
==========================================
  Files        5264     5107     -157     
  Lines      294867   290738    -4129     
  Branches    59029    57924    -1105     
==========================================
- Hits       254976   251287    -3689     
+ Misses      34950    34510     -440     
  Partials     4941     4941              
Flag Coverage Δ
cli ?
dify-ui 93.49% <ø> (ø)
web 86.11% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 force-pushed the codex/refactor-qrcode-panel-boundary branch from ec07319 to f16de5e Compare August 9, 2026 14:49
@lyzno1
lyzno1 marked this pull request as ready for review August 9, 2026 15:47
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. refactor labels Aug 9, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 10, 2026
@lyzno1
lyzno1 added this pull request to the merge queue Aug 10, 2026
Merged via the queue into main with commit 9c5d76c Aug 10, 2026
43 checks passed
@lyzno1
lyzno1 deleted the codex/refactor-qrcode-panel-boundary branch August 10, 2026 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer refactor size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants