fix(web): use buttons for pricing categories - #40360
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40360 +/- ##
==========================================
- Coverage 86.47% 86.43% -0.05%
==========================================
Files 5264 5107 -157
Lines 294867 290740 -4127
Branches 59029 57924 -1105
==========================================
- Hits 254976 251288 -3688
+ Misses 34950 34511 -439
Partials 4941 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
marked this pull request as ready for review
August 9, 2026 15:47
hjlarry
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aria-pressedBoundary
Tabowner, its existing integration test, and the suppression baselineValidation
pnpm --dir web exec vp test run __tests__/billing/pricing-modal-flow.test.tsx— 20/20 passed./node_modules/.bin/vp lint web/app/components/billing/pricing/plan-switcher/tab.tsx web/__tests__/billing/pricing-modal-flow.test.tsxpnpm --dir web lint:a11y app/components/billing/pricing/plan-switcher/tab.tsxpnpm check— 0 errors, 2059 existing warningsgit diff --checkVisual regression review
appearance-noneprevents platform button chrome; the explicit flex centering matches the previous containersStack
Independent root PR based directly on current
origin/main; no child cleanup is required.Rollback
Revert commit
19415761dc; no other accessibility PR depends on this branch.