Skip to content

fix(web): use button for publisher access - #40361

Queued
lyzno1 wants to merge 3 commits into
mainfrom
codex/a11y-publisher-access-button
Queued

fix(web): use button for publisher access#40361
lyzno1 wants to merge 3 commits into
mainfrom
codex/a11y-publisher-access-button

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • replace the publisher access-settings container with a native button
  • retain the access mode and missing-subject warning as its accessible name
  • verify Enter opens the owner callback
  • use valid inline wrappers inside the button
  • remove the two matching suppressions

Visual regression review

The row remains 32px high and full width with identical padding, gap, radius, background, hover, truncation, and arrow alignment. appearance-none, border-0, and text-start preserve normal pixels and logical alignment. The only intended new state is the keyboard focus-visible ring.

Verification

  • owner suite: 8/8 passed
  • standalone a11y lint: 0 diagnostics
  • full static check: 0 errors
  • suppression delta: -2
  • diff check: passed

Dependency and rollback

Independent root layer. The access dialog and form are outside this change.

@lyzno1 lyzno1 changed the title codex/a11y publisher access button fix(web): use button for publisher access Aug 9, 2026
@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.43%. Comparing base (7522ae1) to head (7b33521).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40361      +/-   ##
==========================================
- Coverage   86.47%   86.43%   -0.05%     
==========================================
  Files        5264     5107     -157     
  Lines      294867   290740    -4127     
  Branches    59029    57924    -1105     
==========================================
- Hits       254976   251289    -3687     
+ Misses      34950    34510     -440     
  Partials     4941     4941              
Flag Coverage Δ
cli ?
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 marked this pull request as ready for review August 9, 2026 15:47
@lyzno1
lyzno1 requested review from iamjoel and zxhlyh as code owners August 9, 2026 15:47
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Aug 9, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 10, 2026
@lyzno1
lyzno1 added this pull request to the merge queue Aug 10, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants