Skip to content

fix(web): associate app deletion confirmation label - #40375

Queued
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-app-delete-confirmation-label
Queued

fix(web): associate app deletion confirmation label#40375
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-app-delete-confirmation-label

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Associate the existing visible deletion-confirmation label with its input through React.useId(), htmlFor, and id.
  • Preserve the localized instruction as the textbox accessible name.
  • Remove the exact label-has-associated-control suppression made obsolete by this change.

Boundary

  • No Input or AlertDialog migration.
  • No submission, state, copy, class, spacing, or layout changes.
  • The separately baselined legacy Input import remains out of scope.
  • Dify UI documents Form and Field migration as a submit-boundary and primitive migration; that larger visual and behavioral change belongs in its own reviewed stack, not this label-only PR.

Validation

  • Added the semantic role/name test first and observed it fail before implementation.
  • pnpm --dir web exec vp test run app/components/app-sidebar/app-info/__tests__/app-info-modals.spec.tsx: 18/18 passed.
  • pnpm check: passed with 0 errors; existing warnings remain baselined.
  • Targeted lint, format, and git diff --check: passed.
  • Standalone accessibility lint no longer reports label-has-associated-control; it still reports the pre-existing restricted legacy Input import.

Visual review

  • Expected visual delta: none. The rendered boxes, classes, text, and DOM nesting are unchanged; only id and for attributes are added.
  • Intended behavior delta: clicking the visible label now focuses the confirmation input.

Rollback

  • Revert commit bb321beb25eddb65e8d211be38d7a2fb1b84c867. This PR is an independent root and has no child dependency.

From Codex.

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@lyzno1 lyzno1 changed the title codex/a11y app delete confirmation label fix(web): associate app deletion confirmation label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.43%. Comparing base (7522ae1) to head (bb321be).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #40375      +/-   ##
==========================================
- Coverage   86.47%   86.43%   -0.05%     
==========================================
  Files        5264     5107     -157     
  Lines      294867   290741    -4126     
  Branches    59029    57924    -1105     
==========================================
- Hits       254976   251290    -3686     
+ Misses      34950    34510     -440     
  Partials     4941     4941              
Flag Coverage Δ
cli ?
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lyzno1
lyzno1 marked this pull request as ready for review August 9, 2026 15:47
@lyzno1
lyzno1 requested review from JzoNgKVO and iamjoel as code owners August 9, 2026 15:47
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Aug 9, 2026
@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Aug 10, 2026
@lyzno1
lyzno1 added this pull request to the merge queue Aug 10, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants