fix(web): associate app deletion confirmation label - #40375
Queued
lyzno1 wants to merge 1 commit into
Queued
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #40375 +/- ##
==========================================
- Coverage 86.47% 86.43% -0.05%
==========================================
Files 5264 5107 -157
Lines 294867 290741 -4126
Branches 59029 57924 -1105
==========================================
- Hits 254976 251290 -3686
+ Misses 34950 34510 -440
Partials 4941 4941
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
lyzno1
marked this pull request as ready for review
August 9, 2026 15:47
hjlarry
approved these changes
Aug 10, 2026
lyzno1
added this pull request to the merge queue
Aug 10, 2026
Any commits made after this event will not be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
React.useId(),htmlFor, andid.label-has-associated-controlsuppression made obsolete by this change.Boundary
FormandFieldmigration as a submit-boundary and primitive migration; that larger visual and behavioral change belongs in its own reviewed stack, not this label-only PR.Validation
pnpm --dir web exec vp test run app/components/app-sidebar/app-info/__tests__/app-info-modals.spec.tsx: 18/18 passed.pnpm check: passed with 0 errors; existing warnings remain baselined.git diff --check: passed.label-has-associated-control; it still reports the pre-existing restricted legacy Input import.Visual review
idandforattributes are added.Rollback
bb321beb25eddb65e8d211be38d7a2fb1b84c867. This PR is an independent root and has no child dependency.From Codex.