Repository navigation
Close detach() properly; stop re-running startup code on every disconnect - #1
Merged
Merged
Conversation
…nect detach() was missing its closing brace, so it swallowed a duplicate copy of the top-level startup code. Every disconnect re-registered the erase, full-screen, fullscreenchange and resize listeners, re-ran the service-worker cleanup and finalizeInterrupted(), and re-read settings. The duplicate first appeared in 82be485 and grew with each later commit. Remove the nested copy (identical to the real top-level code) and keep detach()'s own body, including the updateWakeLock() call it had before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
detach()inweb/js/main.jswas missing its closing brace, so it contained a duplicate copy of the top-level startup code. Every disconnect re-registered the erase, full-screen,fullscreenchangeandresizelisteners, re-ran the service-worker cleanup andfinalizeInterrupted(), and re-read settings. The duplicate first appeared in 82be485 and grew with each later commit.detach()'s own body, including theupdateWakeLock()call it had from the start.Testing
node --check js/main.jspassesnpm test: 54 pass, 0 fail, 4 skippedexitFullscreenonce. Still worth a tap on a real phone.