Added Strong & Emphasis formatter#68
Open
stephanheilner wants to merge 3 commits intolaptobbe:masterfrom
Open
Conversation
Collaborator
|
Thank you @stephanheilner. As DaringFireball is effectively supporting this combination, I'll accept this workaround for branch 2.x. Note that branch 3.x will work differently, with traits. |
Coeur
reviewed
Mar 5, 2018
| [attributedString addAttributes:weakParser.emphasisAttributes range:range]; | ||
| }]; | ||
|
|
||
| [defaultParser addStrongAndEmphasisParsingWithFormattingBlock:^(NSMutableAttributedString *attributedString, NSRange range) { |
Collaborator
There was a problem hiding this comment.
I may move this line before Strong and Emphasis.
Coeur
reviewed
Mar 5, 2018
TSMarkdownParser/TSMarkdownParser.m
Outdated
| #endif | ||
| _strongAttributes = @{ NSFontAttributeName: [UIFont boldSystemFontOfSize:defaultSize] }; | ||
|
|
||
| _strongAndEmphasisAttributes = @{ NSFontAttributeName: [UIFont fontWithDescriptor:[[[UIFont systemFontOfSize:defaultSize] fontDescriptor] fontDescriptorWithSymbolicTraits:(UIFontDescriptorTraitBold | UIFontDescriptorTraitItalic)] size:defaultSize] }; |
Collaborator
There was a problem hiding this comment.
not building on macOS target or iOS 6
Collaborator
|
Ah, well, sadly, it doesn't work for iOS 6 and macOS, so it's better to wait for TSMarkdownParser 3.0, as it will give proper support for it. |
Coeur
requested changes
Mar 5, 2018
Collaborator
Coeur
left a comment
Coeur
left a comment
There was a problem hiding this comment.
needs to keep compatibility with macOS target
stephanheilner
force-pushed
the
strong_emphasis
branch
from
332b9bb to
05f162e
Compare
stephanheilner
force-pushed
the
strong_emphasis
branch
from
0abcbb1 to
f5080a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.