Skip to content

test: drop stale e2e yes flags#794

Open
yxzhaao wants to merge 1 commit intolarksuite:mainfrom
yxzhaao:fix/drop-stale-e2e-yes-flags
Open

test: drop stale e2e yes flags#794
yxzhaao wants to merge 1 commit intolarksuite:mainfrom
yxzhaao:fix/drop-stale-e2e-yes-flags

Conversation

@yxzhaao
Copy link
Copy Markdown
Contributor

@yxzhaao yxzhaao commented May 9, 2026

Summary

Changes

  • Change 1
  • Change 2

Test Plan

  • Unit tests pass
  • Manual local verification confirms the lark xxx command works as expected

Related Issues

  • None

Summary by CodeRabbit

  • Tests
    • Updated calendar management and spreadsheet creation CLI end-to-end tests to reflect changes in confirmation handling behavior.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8fa2174d-33f3-453f-a153-2ccc181b485e

📥 Commits

Reviewing files that changed from the base of the PR and between 44ffa98 and 71e218c.

📒 Files selected for processing (2)
  • tests/cli_e2e/calendar/calendar_manage_calendar_test.go
  • tests/cli_e2e/sheets/sheets_crud_workflow_test.go
💤 Files with no reviewable changes (2)
  • tests/cli_e2e/sheets/sheets_crud_workflow_test.go
  • tests/cli_e2e/calendar/calendar_manage_calendar_test.go

📝 Walkthrough

Walkthrough

This PR removes the Yes: true confirmation flag from three e2e test invocations: two in calendar resource tests (create and update) and one in the sheets spreadsheet create test. Request payloads and assertions remain unchanged.

Changes

E2E Test Flag Cleanup

Layer / File(s) Summary
Test Flag Removal
tests/cli_e2e/calendar/calendar_manage_calendar_test.go, tests/cli_e2e/sheets/sheets_crud_workflow_test.go
Yes: true confirmation field removed from calendar create, calendar patch, and spreadsheet create e2e test requests; payloads and assertions unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • larksuite/cli#633: Added the --yes confirmation flow and Request.Yes field; this PR removes that flag from specific e2e tests.
  • larksuite/cli#701: Also modifies the Yes confirmation flag presence in e2e tests, including calendar tests.

Suggested labels

size/S

Suggested reviewers

  • liangshuo-1
  • liuxinyanglxy

Poem

A rabbit hops through tests with glee,
Removing flags for clarity,
No more "Yes" to confirm,
Simpler flows, let workflows churn! 🐰✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description contains only the template placeholders with no actual content filled in (Summary and Changes sections are empty, Test Plan unchecked). Fill in the Summary section with the motivation for removing the flags, update Changes with specific file modifications, and check applicable Test Plan items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'test: drop stale e2e yes flags' clearly and specifically summarizes the main change: removing unnecessary confirmation flags from e2e tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added the size/S Low-risk docs, CI, test, or chore only changes label May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/S Low-risk docs, CI, test, or chore only changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant