LATX, fix:Prevent HID ioctl handling from interfering with v4l2 ioctls#214
Merged
Conversation
The HID ioctl handling code was incorrectly intercepting v4l2 ioctl commands due to overlapping ioctl number (nr) values. Specifically, v4l2 commands with nr=4 were matching HIDIOCGRAWNAME(0) which also has nr=4.
Contributor
|
@lk-me After this commit, some fingerprint input devices became unrecognized.The issue has been fixed in this PR（https://github.com/lat-opensource/lat/pull/290）. Please help review the PR to confirm whether it will impact the current PR. |
Contributor
Author
|
@zhaodong This PR can be opened normally with the previous V4L2 camera. |
Contributor
|
@lk-me Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HID ioctl handling code was incorrectly intercepting v4l2 ioctl commands
due to overlapping ioctl number (nr) values. Specifically, v4l2 commands with
nr=4 were matching HIDIOCGRAWNAME(0) which also has nr=4.
Changes:
This ensures v4l2 ioctls (type='V'/0x56) are not incorrectly processed as HID
ioctls, fixing v4l2 device opening failures.