Skip to content

feat(icons): sync and connect icons with figma library#1875

Merged
nhironaka merged 2 commits intomainfrom
ci/feat/sync-icons
Apr 7, 2026
Merged

feat(icons): sync and connect icons with figma library#1875
nhironaka merged 2 commits intomainfrom
ci/feat/sync-icons

Conversation

@pd-sa-github-launchpad-ui
Copy link
Copy Markdown
Contributor

@pd-sa-github-launchpad-ui pd-sa-github-launchpad-ui commented Apr 2, 2026

Summary

This PR is an automated icon sync with LaunchPad Figma library. If you resync while this PR is open, the updated changes will be added to this same PR.

New icons:

  • restore

Open with Devin

Note

Medium Risk
Primarily asset updates, but it also changes the existing scale SVG path, which could cause visual regressions anywhere that icon is used.

Overview
Syncs the icon set with the LaunchPad Figma library by adding the new restore icon across the package (sprite, IconName types, and Figma code-connect mappings).

Also updates the existing scale icon’s SVG definition in sprite.svg, changing its rendered shape. Includes a patch changeset for @launchpad-ui/icons.

Reviewed by Cursor Bugbot for commit 727d65a. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 2, 2026

🦋 Changeset detected

Latest commit: 727d65a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@launchpad-ui/icons Patch
@launchpad-ui/button Patch
@launchpad-ui/components Patch
@launchpad-ui/drawer Patch
@launchpad-ui/dropdown Patch
@launchpad-ui/filter Patch
@launchpad-ui/form Patch
@launchpad-ui/menu Patch
@launchpad-ui/modal Patch
@launchpad-ui/navigation Patch
@launchpad-ui/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Apr 2, 2026

yarn add https://pkg.pr.new/@launchpad-ui/components@1875.tgz
yarn add https://pkg.pr.new/@launchpad-ui/icons@1875.tgz
yarn add https://pkg.pr.new/@launchpad-ui/tokens@1875.tgz

commit: 727d65a

@antonio-darkly antonio-darkly marked this pull request as ready for review April 3, 2026 16:31
@antonio-darkly antonio-darkly requested review from a team as code owners April 3, 2026 16:31
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

</symbol>
<symbol id="lp-icon-scale" viewBox="0 0 20 20">
<path d="M9.25 2.5a.75.75 0 0 1 1.5 0v1.03l4.373.73c.237.04.44.19.548.405l2.5 5a.75.75 0 0 1 .079.335 3.25 3.25 0 0 1-6.5 0 .75.75 0 0 1 .08-.335l2.045-4.093-3.125-.52v10.865h3.417a.75.75 0 0 1 0 1.5H5.833a.75.75 0 0 1 0-1.5H9.25V5.052l-3.126.52 2.047 4.093A.75.75 0 0 1 8.25 10a3.25 3.25 0 0 1-6.5 0 .75.75 0 0 1 .08-.335l2.5-5 .044-.078a.75.75 0 0 1 .503-.327l4.373-.73zm-5.992 7.66a1.75 1.75 0 0 0 3.483 0L5 6.677zm10 0a1.75 1.75 0 0 0 3.483 0L15 6.677z"/>
<path fill-rule="evenodd" d="M10 1c.403 0 .73.345.73.771v1.404l4.741.92a.7.7 0 0 1 .158.05 1 1 0 0 1 .108.057l.021.016a.7.7 0 0 1 .168.167l.023.031q.031.045.055.097l2.919 6.171c.05.107.077.225.077.345a3.97 3.97 0 0 1-1.069 2.727 3.55 3.55 0 0 1-2.58 1.13 3.55 3.55 0 0 1-2.58-1.13 3.97 3.97 0 0 1-1.068-2.727c0-.12.026-.238.077-.345l2.477-5.237-3.527-.707v12.717h4.135c.403 0 .73.345.73.772 0 .426-.327.771-.73.771h-9.73c-.403 0-.73-.345-.73-.771s.327-.772.73-.772H9.27V4.74l-3.527.707 2.477 5.237c.05.107.077.225.077.345a3.97 3.97 0 0 1-1.069 2.727 3.55 3.55 0 0 1-2.58 1.13 3.55 3.55 0 0 1-2.58-1.13A3.97 3.97 0 0 1 1 11.029c0-.12.026-.238.077-.345l2.919-6.171a1 1 0 0 1 .054-.097l.023-.031a.8.8 0 0 1 .168-.167l.02-.016a1 1 0 0 1 .11-.057.7.7 0 0 1 .158-.05l4.741-.92V1.77c0-.426.327-.771.73-.771M2.466 11.194a2.37 2.37 0 0 0 .635 1.47c.41.435.967.679 1.548.679a2.13 2.13 0 0 0 1.547-.678c.374-.395.597-.917.634-1.47L4.65 6.581zm10.703 0a2.37 2.37 0 0 0 .634 1.47 2.13 2.13 0 0 0 1.548.679 2.13 2.13 0 0 0 1.548-.678c.374-.395.596-.917.634-1.47L15.35 6.581z" clip-rule="evenodd"/>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scale icon SVG path silently replaced with different coordinates

Medium Severity

The lp-icon-scale SVG path was completely replaced even though the PR description only lists restore as a new icon. The new path uses a different coordinate system (values like .771, .772, .403, .345, .426, .327) that doesn't match the library's standard grid fractions (.75, .25, .917, .083). This will change the visual appearance of the existing scale icon for all consumers, which appears unintended by the automated sync.

Fix in Cursor Fix in Web

@nhironaka nhironaka merged commit c21e7b3 into main Apr 7, 2026
21 checks passed
@nhironaka nhironaka deleted the ci/feat/sync-icons branch April 7, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants