chore: Add image validation for Gatsby components and enhance error handling #7213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…andling Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
… dedicated runtime chunk plus explicit framework and vendor cache groups Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
…Data Signed-off-by: Lee Calcote <lee.calcote@layer5.io>
Contributor
|
Build failing |
Member
Author
Clearly, it is. This sort of feedback isn't helpful. |
Signed-off-by: Lee Calcote <leecalcote@gmail.com>
| return renderBasicImage({ publicURL, alt, imgStyle, ...rest }); | ||
| } | ||
|
|
||
| if (!childImageSharp?.gatsbyImageData) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!childImageSharp?.gatsbyImageData) { | |
| const gatsbyImageData = childImageSharp.gatsbyImageData; | |
| if (!gatsbyImageData) { |
| return renderBasicImage({ publicURL, alt, imgStyle, ...rest }); | ||
| } | ||
|
|
||
| const gatsbyImageData = childImageSharp.gatsbyImageData; |
Contributor
There was a problem hiding this comment.
Suggested change
| const gatsbyImageData = childImageSharp.gatsbyImageData; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lee Calcote lee.calcote@layer5.io
Description
A new
maketarget:check-imagesreports if any<GatsbyImage />lacking an explicit image prop (exit code 1 when issues are found).To narrow the scan to a folder with
make check-images -- src/pages/community. This script is useful as a guardrail.