refactor: one object path: galaxies, clusters and nebulae are ordinary scenes - #1088
Merged
Merged
Conversation
…placed bodies of the world context, not catalogue rows
…t from its own descriptor, and a world object like any scene
alowpoly
added
the
pipeline-change
# Conflicts: # packages/renderer/src/universe/world-context/world-context-planner.ts # src/objects/sun/inventory.json
alowpoly
changed the title
alowpoly
changed the title
… not by selected id; the system card finds its detached containers
…osts its member-dots bank; standard lanes accept no surface
…hosts its member-dots bank
… hosts its image-layer bank; a bank names its host
… which a split galaxy keeps
…with no surface that host their layer banks
…e bank-as-object registry and preparer
…atalogue link leads there
…oom ladder is a view of a scene, kept in its own short list
…s, and a point-bank companion keeps its context lit
# Conflicts: # packages/renderer/src/universe/prepared-universe-runtime.ts # public/navigation/body-markers-14@2x.webp # src/objects/sun/inventory.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Galaxies, clusters and nebulae went through a second object path: catalogue rows, their own selection, card and preparer. Now there is one. Each of the 18 is an ordinary authored object whose recipe declares no surface, and its imagery is a context bank the object's dataset names, as Beta Pictoris names its disc. The standard lanes, card and dataset list serve them.
Before:
After:
Limits: the Hydra, Centaurus, Norma, Perseus and Coma cluster pages go away (no package). The camera stops 1.2 framing radii from a galaxy or nebula. Zoom levels still use their own card.
Clean: the three typechecks, the site tests and the package tests.