fix(nearby-universe): galaxies with a Hubble Cepheid distance sit at it, among their Cepheids - #1104
Merged
Merged
Conversation
…it, among their Cepheids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 168 packaged Cepheids of NGC 1365, 4424, 4536 and 4639 sit at their galaxy's Hubble Cepheid distance (Riess et al. 2016), but the Nearby Universe drew those galaxies elsewhere: at their group's average (up to 2.1 Mpc away) or, for NGC 4536, at its redshift's distance, 17 Mpc away. Now the 19 galaxies with a Cepheid distance in that paper are placed by it (18 Cosmicflows-4 rows, one 2MRS row; NGC 3021 moved 5.6 Mpc), so each galaxy's dot is among its Cepheids. A catalogue table can name such rows with
measuredDistance.Limits: no images, the 19 rows were checked numerically in the prepared banks, not on screen; a 2MRS row is drawn at the innermost level only when the one-in-three thinning keeps it; the dot bank is 39,903 dots, one fewer than before.
Clean: bake volume tests (13) including the new placement test; universe and catalogue site tests (8); typecheck of bake and telescope-cli; no-hashes check.