fix(ci): the bake tests that exercise the renderer run when the renderer changes - #1106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Plan 4 / C2 moved renderer tests that import the bake into
packages/bake. The CI selector (affected-tests.mts) joins the offline tools only when a tool changed, so on a renderer-only change those suites stopped running.Re-including all of bake on a renderer change would restore them, but bake's whole suite is heavy and was deliberately excluded. Instead an explicit owner map,
FOREIGN_TESTS, lists exactly the moved suites and the selector runs just those files when their owner (or a package it depends on) changed. A unit test guards the map: every entry must exist, sit in an offline tool and import its owner package.What changed
affected-tests.mts:FOREIGN_TESTS, afilesresult and a newtest_filesoutput; a file whose own package already runs is left to that package's glob.universe.yml:test_filesis exported bychanges, passed to the packages lane asCI_TEST_FILESand appended to thetestsarray; the lane is skipped only when both packages and files are empty.check-ci.mts: the local run substitutes the new output and the updated skip expression.CONTRIBUTING.md: the selector rule names the exception.The 12 files are the 11 renderer tests moved by f309c5c (scientific-focus excluded: it runs in the integration lane, covered by the site lane) plus the prepared-volume-runtime test moved by 72803ea.
Checks
testsloop, run for real withCI_TEST_PACKAGES=rendererand the 12 files: the foreign files execute (87 tests, 0 fail).falsefails 3 tests inaffected-tests.test.mts; restored, all 6 pass.affected-tests.test.mtsandcheck-ci.test.mts: 7 pass..github/scripts,typecheck:scripts, documentation links (--base origin/main), architecture check and the commit-message range check pass.See the PR rules.