Repository navigation
fix(stars): draw the dark step of Color + brightness at 2.2 times the star chroma - #1592
Merged
Merged
Conversation
alowpoly
added
the
pipeline-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Color + brightness drew its darkest part 0.12 higher in chroma (OKLCH) than the star's color, ten times the chroma of a nearly white star, so a faint hue became strong: HD 73344's Gaia color
#fcf6ffdrew violet, Sun-like stars drew rose. The dark step is now 2.2 times the star's own chroma (DARK_STEP), which is what 0.12 gave AU Mic's orange, on which the step was chosen: AU Mic's scale is unchanged. The faint hue itself is Gaia's: on 8 Sun-like HST reference stars, Gaia's XP spectra give hues 3 to 30° pinker than HST's spectra of the same stars, through the same code. 123 stars change; 8 of main's 131 keep identical scales (AU Mic, K2-122, K2-136, K2-25, Kepler-94, ROXs 42B, TOI-540, Udkadua).Limits: the 11 stars of #1590 are not on main; that PR takes the same rule for them.
Clean: 18 map tests, check-color-spelling, check-no-hashes.