Repository navigation
refactor: clear the repository audit's ignore, lint and directory growth failures - #1593
Merged
Merged
Conversation
… and drop a disable for an uninstalled rule
…ython ports and the far picture bake into folders
… face subfolders and move face preparation out of prepare
…cience and models subfolders by import graph
…alaxy and galaxy-stations subfolders by import graph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The repository audit failed on
mainin three steps. This makes all three pass without changing what the site does.packages/bake/src/image-layers/prepare.ts(641 lines) is under the 600-line limit, with its photo clean-up step moved unchanged intoimage-layers/face/face.ts.packages/renderer/src/universepoints/,clouds/,galaxy/,galaxy-stations/packages/telescope-cli/srccli/packages/telescope-cli/src/archives/interferometryalma/packages/telescope-cli/src/new-object/archivescepheids/packages/bake/src/image-layerssurface/,collision/,rings/,face/packages/telescope-core/src/nodescience/,models/packages/bake/cliastronomy-data/(the 19 ledger commands)packages/bake/authoring/homunculus-nebula/outer-ejectapython-ports/packages/bake/authoring/milky-way-dustfar-planes/The astronomy data commands now run as
node packages/bake/cli/astronomy-data/astronomy-data-<name>.mts. Their usage lines, the audit workflow and the source README are updated. Imports, build configs, package aliases, body READMEs and docs follow every moved path..github/site-refactor.jsondeclares the renderer moves as a pure move, so CI compares the complete built site withmain.Evidence and limits
Audit steps, run locally:
main;pnpm linthas 0 errors (the threemax-lineswarnings remain warnings);pnpm check:directory-growthpasses.Clean:
pnpm typecheck,pnpm check:architecture, the bake, renderer, telescope and telescope-core builds, and every moved folder's tests.