Repository navigation
feat(minimaps): centre a star-locked planet's map picture on the side that faces its star - #1598
Merged
Merged
Conversation
… that faces its star
alowpoly
added
the
pipeline-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A planet locked to its star showed its flat map split in two: the day side half on each edge and the night side in the middle, because the picture starts at longitude 0, which is the point facing the star. A planet whose rotation record is
cssearth-synchronous-rotation@1and that has no framing record of its own now has its map picture centred on longitude 0. This is the same framing 144 moons already declare, read in one place (readMinimapCenter) by the minimap step, the default camera's coverage and the map-edge check. 40 planets change, 129 pictures in all. 102 more were redrawn and came out byte for byte the same, because they are one flat color.Before and after: TRAPPIST-1e, starlight on the ground, day 1; WASP-43b, temperature.
Limits: GJ 1252 b, GJ 367 b, GJ 3929 b, LHS 1140 c and LTT 3780 b keep their split pictures until SVO answers again. Their filter curves and stellar spectra are not in the source mirror, and the minimap step needs every source. This PR is stacked on #1597.
prepare-surface-minimaps.mts) of 142 star-locked planets: 129 pictures in 40 planets changed.publish-runtime-assets.mts): 132 keys verified live.inventory.jsonfiles, and no baked files.Clean:
surface-minimaps(new case),scientific-minimaps,dataset-facinganddefault-cameratests 18/18; baketsc,typecheck:shell, eslint on the changed files;check-no-hashes,check-prepared-delivery,check-color-spelling.