Skip to content

Update WhmDelegateImpl.cpp#2

Draft
lboue wants to merge 1 commit into
masterfrom
EnergyManagementLED
Draft

Update WhmDelegateImpl.cpp#2
lboue wants to merge 1 commit into
masterfrom
EnergyManagementLED

Conversation

@lboue

@lboue lboue commented Nov 22, 2024

Copy link
Copy Markdown
Owner

EnergyManagementLED

!!!!!!!!!! Please delete the instructions below and replace with PR description

If you have an issue number, please use a syntax of
Fixes #12345 and a brief change description

If you do not have an issue number, please have a good description of
the problem and the fix. Help the reviewer understand what to expect.

Make sure you delete these instructions (to prove you have read them).

!!!!!!!!!! Instructions end

@lboue
Update WhmDelegateImpl.cpp
7d544fc 
EnergyManagementLED
@github-actions

github-actions Bot commented May 22, 2025

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had recent activity.

@github-actions github-actions Bot added the Stale label May 22, 2025
lboue pushed a commit that referenced this pull request Mar 13, 2026
@pimpalemahesh
[Code Driven]: #2 – Move Cluster Headers to Code driven style (projec…
b2c44f5 
…t-chip#43203)

* closure-control: move code to new cluster headers while keeping backward

* Added shim files for backward compatibility

* updated copyright year for shim files
@Sum1cares

Sum1cares commented Mar 14, 2026

Copy link
Copy Markdown

Awesome

@Sum1cares

Sum1cares commented Mar 14, 2026

Copy link
Copy Markdown

Awesome

Sum1cares
Sum1cares approved these changes Mar 14, 2026
View reviewed changes

@Sum1cares Sum1cares left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@github-actions github-actions Bot removed the Stale label Mar 15, 2026
lboue pushed a commit that referenced this pull request May 16, 2026
@Hayk10002
Migrate PowerSource cluster to codedriven implementation PR #2 (move …
055a802 
…codegen to `codegen/` subdir) (project-chip#72062)

* Revert "Migrate `PowerSource` cluster to codedriven implementation PR #1 (file rename) (project-chip#43135)"

This reverts commit c5f2b0f.

* Move current codegen to `codegen/` subdir

* Fix some naming issues
lboue pushed a commit that referenced this pull request Jun 4, 2026
@andy31415
Always clear all signal handlers on app exists. (project-chip#72156)
27fd2cc 
CI reports a memory leak:

```
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.521 - APP  STDERR: Direct leak of 128 byte(s) in 1 object(s) allocated from:
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.522 - APP  STDERR:     #0 0x000103639354 in calloc+0x78 (libclang_rt.asan_osx_dynamic.dylib:arm64+0x55354)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.523 - APP  STDERR:     #1 0x00018ca6c6ec in _malloc_type_calloc_outlined+0x64 (libsystem_malloc.dylib:arm64e+0x1e6ec)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.523 - APP  STDERR:     #2 0x00018c7ff7d8 in class_createInstance+0x48 (libobjc.A.dylib:arm64e+0x77d8)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.523 - APP  STDERR:     project-chip#3 0x00018caa184c in _os_object_alloc_realized+0x1c (libdispatch.dylib:arm64e+0x284c)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.524 - APP  STDERR:     project-chip#4 0x00018cab588c in dispatch_source_create+0x38 (libdispatch.dylib:arm64e+0x1688c)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.525 - APP  STDERR:     project-chip#5 0x00010278e354 in chip::DeviceLayer::PlatformManagerImpl::RegisterSignalHandler(int, void () block_pointer)+0x3ec (lit-icd-app:arm64+0x1005b2354)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.525 - APP  STDERR:     project-chip#6 0x0001022a1cf8 in ChipLinuxAppMainLoop(chip::ServerInitParams&, AppMainLoopImplementation*)+0x1960 (lit-icd-app:arm64+0x1000c5cf8)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.525 - APP  STDERR:     project-chip#7 0x0001021dde3c in main+0x9a0 (lit-icd-app:arm64+0x100001e3c)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.526 - APP  STDERR:     project-chip#8 0x00018c89fda0 in start+0x1b4c (dyld:arm64e+0x1fda0)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.526 - APP  STDERR: 
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.527 - APP  STDERR: Indirect leak of 80 byte(s) in 1 object(s) allocated from:
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.527 - APP  STDERR:     #0 0x000103639354 in calloc+0x78 (libclang_rt.asan_osx_dynamic.dylib:arm64+0x55354)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.527 - APP  STDERR:     #1 0x00018ca6c6ec in _malloc_type_calloc_outlined+0x64 (libsystem_malloc.dylib:arm64e+0x1e6ec)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.527 - APP  STDERR:     #2 0x00018caa0918 in _dispatch_calloc_typed+0x20 (libdispatch.dylib:arm64e+0x1918)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.529 - APP  STDERR:     project-chip#3 0x00018cac0838 in _dispatch_unote_create+0x8c (libdispatch.dylib:arm64e+0x21838)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.529 - APP  STDERR:     project-chip#4 0x00018cab5874 in dispatch_source_create+0x20 (libdispatch.dylib:arm64e+0x16874)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.530 - APP  STDERR:     project-chip#5 0x00010278e354 in chip::DeviceLayer::PlatformManagerImpl::RegisterSignalHandler(int, void () block_pointer)+0x3ec (lit-icd-app:arm64+0x1005b2354)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.530 - APP  STDERR:     project-chip#6 0x0001022a1cf8 in ChipLinuxAppMainLoop(chip::ServerInitParams&, AppMainLoopImplementation*)+0x1960 (lit-icd-app:arm64+0x1000c5cf8)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.530 - APP  STDERR:     project-chip#7 0x0001021dde3c in main+0x9a0 (lit-icd-app:arm64+0x100001e3c)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.530 - APP  STDERR:     project-chip#8 0x00018c89fda0 in start+0x1b4c (dyld:arm64e+0x1fda0)
```

Normally if we only stop on signal handlers, the clear should have
happened... however it seems it does not, so moving the logic to
become unconditional, in case we have other ways to stop the app.
lboue pushed a commit that referenced this pull request Jun 22, 2026
@andy31415 @lboue
Always clear all signal handlers on app exists. (project-chip#72156)
0c4a991 
CI reports a memory leak:

```
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.521 - APP  STDERR: Direct leak of 128 byte(s) in 1 object(s) allocated from:
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.522 - APP  STDERR:     #0 0x000103639354 in calloc+0x78 (libclang_rt.asan_osx_dynamic.dylib:arm64+0x55354)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.523 - APP  STDERR:     #1 0x00018ca6c6ec in _malloc_type_calloc_outlined+0x64 (libsystem_malloc.dylib:arm64e+0x1e6ec)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.523 - APP  STDERR:     #2 0x00018c7ff7d8 in class_createInstance+0x48 (libobjc.A.dylib:arm64e+0x77d8)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.523 - APP  STDERR:     project-chip#3 0x00018caa184c in _os_object_alloc_realized+0x1c (libdispatch.dylib:arm64e+0x284c)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.524 - APP  STDERR:     project-chip#4 0x00018cab588c in dispatch_source_create+0x38 (libdispatch.dylib:arm64e+0x1688c)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.525 - APP  STDERR:     project-chip#5 0x00010278e354 in chip::DeviceLayer::PlatformManagerImpl::RegisterSignalHandler(int, void () block_pointer)+0x3ec (lit-icd-app:arm64+0x1005b2354)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.525 - APP  STDERR:     project-chip#6 0x0001022a1cf8 in ChipLinuxAppMainLoop(chip::ServerInitParams&, AppMainLoopImplementation*)+0x1960 (lit-icd-app:arm64+0x1000c5cf8)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.525 - APP  STDERR:     project-chip#7 0x0001021dde3c in main+0x9a0 (lit-icd-app:arm64+0x100001e3c)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.526 - APP  STDERR:     project-chip#8 0x00018c89fda0 in start+0x1b4c (dyld:arm64e+0x1fda0)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.526 - APP  STDERR: 
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.527 - APP  STDERR: Indirect leak of 80 byte(s) in 1 object(s) allocated from:
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.527 - APP  STDERR:     #0 0x000103639354 in calloc+0x78 (libclang_rt.asan_osx_dynamic.dylib:arm64+0x55354)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.527 - APP  STDERR:     #1 0x00018ca6c6ec in _malloc_type_calloc_outlined+0x64 (libsystem_malloc.dylib:arm64e+0x1e6ec)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.527 - APP  STDERR:     #2 0x00018caa0918 in _dispatch_calloc_typed+0x20 (libdispatch.dylib:arm64e+0x1918)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.529 - APP  STDERR:     project-chip#3 0x00018cac0838 in _dispatch_unote_create+0x8c (libdispatch.dylib:arm64e+0x21838)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.529 - APP  STDERR:     project-chip#4 0x00018cab5874 in dispatch_source_create+0x20 (libdispatch.dylib:arm64e+0x16874)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.530 - APP  STDERR:     project-chip#5 0x00010278e354 in chip::DeviceLayer::PlatformManagerImpl::RegisterSignalHandler(int, void () block_pointer)+0x3ec (lit-icd-app:arm64+0x1005b2354)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.530 - APP  STDERR:     project-chip#6 0x0001022a1cf8 in ChipLinuxAppMainLoop(chip::ServerInitParams&, AppMainLoopImplementation*)+0x1960 (lit-icd-app:arm64+0x1000c5cf8)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.530 - APP  STDERR:     project-chip#7 0x0001021dde3c in main+0x9a0 (lit-icd-app:arm64+0x100001e3c)
ERROR   [Worker] Test_TC_ICDM_4_1: 15:03:07.530 - APP  STDERR:     project-chip#8 0x00018c89fda0 in start+0x1b4c (dyld:arm64e+0x1fda0)
```

Normally if we only stop on signal handlers, the clear should have
happened... however it seems it does not, so moving the logic to
become unconditional, in case we have other ways to stop the app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Sum1cares Sum1cares Sum1cares approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lboue @Sum1cares