Use git provider tarball download as default way to download git repos#157
Merged
Use git provider tarball download as default way to download git repos#157
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lde | ac025ea | Commit Preview URL Branch Preview URL |
Apr 28 2026, 08:20 AM |
Collaborator
Author
|
This CANNOT not be merged until https://github.com/lde-org/deflate-sys are not using submodules. |
Also fix the test by actually resolving the latest commit and ensuring output is equal
This will be used to faciliate build.lua scripts
Collaborator
Author
|
Should pass when merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most git providers, like GitHub, GitLab, Gitea, etc, provide urls to download a tarball of the source contents of a repository.
This is a much faster download than using git.
Additionally, this PR forces every use of a git repo to be pinned to a commit, using libgit2's lsRemote functionality. Simpler and safer than trying to maintain a "latest" repo with an untagged commit and updating that.
If the git url is not recognized to be GitHub/GitLab/is unsupported, it'll fall back to using git again.
Resolves #151
Breaking change
This will not clone submodules. I've made the decision to no longer support them. It should be up to your build.lua script to grab what is necessary to build your project, or you could provide a tarball of a prebuilt output folder and tell users to use that.
That, or you can check the code into your repo.
I would've liked to keep support, but it seems impossible without cloning git history to be done properly, pinning the submodule's commit to the proper recorded one.
Before
After