Conversation
This was referenced Sep 22, 2026
Komoszek
added this pull request to stack #73
September 22, 2026 06:17
Komoszek
removed this pull request from stack #73
September 22, 2026 06:20
Komoszek
added this pull request to stack #74
September 22, 2026 06:21
Ciach ran the server session and also collected candidates, fetched what the verdict reads, decided each finding, and spelled it: 1000 lines with five jobs. Each is now a collaborator, and Ciach keeps the session and the pipeline. - CandidateCollector: which declarations get checked — the symbol walk, the option filters, entry points and their containers. - ReferenceFetch: the server round trips — references, tokens, syntax nodes — into the SourceIndex. - Settler: from references to sorted findings. - Verdict: what becomes of one unused candidate — suppressed, report-only, or a finding — and its hints. A move, not a change: the tests and the verbose narration are the same. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011fqaUyaQtY7AkuTYBjAUJv
Komoszek
force-pushed
the
claude/issue-58-split-finder
branch
from
September 22, 2026 06:28
bd0fa7e to
e8bee7c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #67. A move, not a change: same tests (278), same
--verbosenarration.Ciachwas ~1000 lines with five jobs. It now keeps the server session and the pipeline (discover → collect → fetch → settle), ~200 lines; each stage is a collaborator, in the patternRemoveSafety,OverrideRemovalsandCrossLibraryReferencesalready follow.candidate_collector.dartreference_fetch.dartSourceIndexsettler.dartverdict.dartCode moved verbatim except:
_toUnused→Verdict.finding,_byLocation→ top-levelcompareByLocation,_semanticTokensOrEmpty→ top-level (the collector and the fetch both need it), andSuperclassChecks/OverrideRemovalsare built once inSettler.settleinstead of inline.🤖 Generated with Claude Code
https://claude.ai/code/session_011fqaUyaQtY7AkuTYBjAUJv