Open
Conversation
Deploying labs-browserpod-previews with
|
| Latest commit: |
5e85802
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c138d902.labs-browserpod-previews.pages.dev |
| Branch Preview URL: | https://publish-showcase.labs-browserpod-previews.pages.dev |
codingfrog27
requested changes
Mar 13, 2026
Contributor
codingfrog27
left a comment
There was a problem hiding this comment.
Nice work! ^^ I've all demo links and URL's seem in order, I have a fair amount of design feedback but they're all just my thoughts. Great job on getting this set up! Let me know if you'd like help with implementing anything, I should have some bandwidth the coming weeks. Excited to have a whole extra page for all our demos!
(potential) errors
- CheerpJ wouldn’t build cause it was missing a japanese translation for the demos. I commented out the check at i18n.ts line 60 to be able to build and test
- Clicking the demos from CJ and BP domains would give 404’s. But I think this might just be due to how they’re deployed? They link to the live labs domain. If I simply paste the demo name at the end of the url it still works
design
You already mentioned there was room for improvement for the banners. I think the same would count for the general layout. Not sure how much of this is not already planned but still in scope, but here are my suggestions:
overview page
- if demos are accessed through a certain product make the background hue colour match said product
- See if we can widen the margins of the demos. Right now it looks good on vertical monitors, but on horizontal ones there’s a lot of dead space on the sides
- With the extra canvas I’d space the cards out a bit more. I think in contrast to the blog posts it’s more about making an impact rather than fitting as many as we can. Maybe add a glow effect around them as well and some extended descriptions.
- Maybe we can fluff up the page banner too? I like the lights image but Maybe we can move the title text behind part of the lights and increase the font size (and maybe a different font too?)
- I wonder how much work it would be to give each demo an internal relevancy score, that we can sort by. I’d say we can hardcode this ourselves despite the maintenance risk. Since integrating analytics like a lot of added complication. And I think internally we have a relatively good idea of which demos we’d like to give the most attention
Demo pages
- Similar layout suggestion, here I’d seuggest pulling the title sidebar a lot more to the left (see image)
- If possible allowing the demo pages to have multiple scrolling images would be a nice addition
- I think not having the leading What is demo and immediately having the description might be stronger. (not 100 on this one though)
- I like the tags! Could we colour their outline? At least the product demo tags
- Should our core products be in the list of demos? Maybe instead we can put them on top (or even bottom) of the page, to distinguish them as “the tools that made all the cool demos possible”
nitpicks
- maybe browsercraft description can be extended a bit, to emphasize the achievement of running jars in the browser. (since its such a big demo)
- maybe Same with javafiddle how it is a free online java Ide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Showcase for project demos
This PR adds several files for the demo showcase, which includes:
What to test
/showcaseNext iterations (after this is approved, separate PR):