feat: Add contraction result for real Lorentz tensors#1086
Open
jstoobysmith wants to merge 5 commits into
Open
feat: Add contraction result for real Lorentz tensors#1086jstoobysmith wants to merge 5 commits into
jstoobysmith wants to merge 5 commits into
Conversation
morrison-daniel
requested changes
May 12, 2026
| Pure.contrPCoeff i j h (Pure.basisVector c b) • | ||
| basis (c ∘ Pure.dropPairEmb i j) (b.dropPair i j) := by | ||
| simp [basis_apply, contrT_pure, Pure.contrP, Pure.dropPair_basisVector] | ||
| rfl |
Collaborator
There was a problem hiding this comment.
Proof ending in rfl usually means there's something not quite right about the definitions, but it's fine since they'll be getting adjusted soon.
Member
Author
There was a problem hiding this comment.
Ok, I didn't know this - this is good to know!
Co-authored-by: Daniel Morrison <39346894+morrison-daniel@users.noreply.github.com>
Member
Author
|
@morrison-daniel Made your requested changes here. |
morrison-daniel
approved these changes
May 14, 2026
morrison-daniel
added
the
ready-to-merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a result related to contractions of real Lorentz tensors.