Conversation
When using an access as a scalar offset, it must be a BIR access pattern, otherwise it will be translated incorrectly down stream.
govereau
requested review from
jiancheng-aws,
joonwonc,
jtristan,
kerrijoe-aws,
ppotapov-aws,
seanmcl,
waahm7 and
yongweiy
as code owners
ppotapov-aws
reviewed
Feb 6, 2026
| let pattern := pattern.map fun (s,c) => Core.APPair.mk s c 0 | ||
| let scalarOffset <- scalar_offset.mapM fun | ||
| | .inl a => pure (.acc a) | ||
| | .inl a => do |
Collaborator
There was a problem hiding this comment.
Keep in mind this triggers the bug in Walrus if we merge
I have a similar PR https://github.com/leanprover/KLR/pull/576/changes. Yours looks better
Collaborator
Author
There was a problem hiding this comment.
Oh, right. Thanks for pointing out.
ppotapov-aws
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using an access as a scalar offset, it must be a BIR access pattern, otherwise it will be translated incorrectly down stream.