Skip to content

fix: add explicit permissions to TypeScript SDK test workflow #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adnanrhussain wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add explicit permissions to TypeScript SDK test workflow #32

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b31e858
fix: add explicit permissions to TypeScript SDK test workflow
adnanrhussain Apr 8, 2026
e10f4cb
re: feedback
adnanrhussain Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 7 additions & 15 deletions .github/workflows/test-sdk-typescript.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,13 @@ on:
- 'evals/prompts/**'
- '.github/workflows/test-sdk-typescript.yml'

permissions:
contents: read

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

Comment on lines +17 to +23
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This repo’s other workflows set permissions at the job level (e.g. .github/workflows/publish-typescript-sdk.yml:11, release-please.yml:10, conventional-commits.yml:16). To stay consistent and keep future least-privilege tighter, consider moving this workflow-level permissions block down into each job (or only jobs that require elevated scopes).

Copilot uses AI. Check for mistakes.
jobs:
lint:
name: 👖 Lint
Expand All @@ -22,9 +29,6 @@ jobs:
run:
working-directory: sdks/typescript
steps:
- name: ⛔ Cancel previous runs
uses: styfle/cancel-workflow-action@0.13.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v6

Expand All @@ -48,9 +52,6 @@ jobs:
run:
working-directory: sdks/typescript
steps:
- name: ⛔ Cancel previous runs
uses: styfle/cancel-workflow-action@0.13.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v6

Expand All @@ -77,9 +78,6 @@ jobs:
matrix:
node-version: ['20.19.0', '22', '24']
steps:
- name: ⛔ Cancel previous runs
uses: styfle/cancel-workflow-action@0.13.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v6

Expand Down Expand Up @@ -107,9 +105,6 @@ jobs:
matrix:
node-version: ['20.19.0', '22', '24']
steps:
- name: ⛔ Cancel previous runs
uses: styfle/cancel-workflow-action@0.13.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v6

Expand Down Expand Up @@ -143,9 +138,6 @@ jobs:
run:
working-directory: sdks/typescript
steps:
- name: ⛔ Cancel previous runs
uses: styfle/cancel-workflow-action@0.13.0

- name: ⬇️ Checkout repo
uses: actions/checkout@v6

Expand Down
Loading