Repository navigation
Migrate generate-automation.js to js-yaml 5 - #125
Merged
Merged
Conversation
- Bump js-yaml to 5.5.0 - Select double quotes with js-yaml 5's `quoteStyle` - Load the registry with the merge tag, which js-yaml 5 drops by default Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rtibblesbot
marked this pull request as ready for review
October 26, 2026 06:39
rtibbles
approved these changes
Nov 6, 2026
Contributor
Author
|
Quick check on rtibblesbot's work on this PR: react 👍 helpful · 😕 mixed · 👎 not helpful. Reply with anything specific. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js-yaml 5 made the generator emit single-quoted strings and a quoted
'on':key, failing the up-to-date check on every generated workflow.quoteStyleoptionReferences
Closes #122. Supersedes #118.
Reviewer guidance
Suggested review: Full code review.
<<merge keys (CORE_SCHEMA.withTags(mergeTag)), which no registry entry uses today.2024-01-01and1_000stay strings, and!!binary/!!set/!!omapthrow.The generate-automation prek hook passes on CI.
AI usage
Claude Code diagnosed the js-yaml 5 output changes and wrote the fix and test. Verified with the test suite, prek, and a write-mode generator run that left generated files unchanged.
Deviations from the issue spec
unquoteOnKeyshould match theonkey as js-yaml 5 emits itquoteStyle: 'double'js-yaml 5 emits"on":, which the existing regex already matchesWritten by rtibblesbot, an LLM-based coding agent.
🟡 Waiting for feedback
Last updated: 2026-10-26 06:40 UTC