determine default base path using window.location#2
Open
cphlipot wants to merge 1 commit into
Open
Conversation
Instead of assuming all the sdcpp APIs are located relative to the origin, instead assume these endpoints are relative to the current location of the loaded UI. This enables use casles like running sd-server and serving it via a reverse proxy (eg. using the separate llama-swap project) and still maintaining functionality of the front end both in the reverse proxy situation as well as just directly running sd-server on localhost. Testing: - run sd-server directly and verify we can still generate an image - run sd-server via llama-swap and verify we can generate an image via the http://localhost:8080/upstream/:model_name url (previously failed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of assuming all the sdcpp APIs are located relative to the
origin, instead assume these endpoints are relative to the current
location of the loaded UI.
This enables use cases like running sd-server and serving it via
a reverse proxy (eg. using the separate llama-swap project) and
still maintaining functionality of the front end both in the reverse
proxy situation as well as just directly running sd-server on localhost.
Testing:
via the http://localhost:8080/upstream/:model_name url which was added in Add /upstream endpoint mostlygeek/llama-swap#31