Repository navigation
fix: enable segmented execution for FLUX.3 - #2224
Conversation
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Mark intermediate forward outputs src/model/diffusion/flux3.hpp |
forward marks each non-final per-mode block output, each mode’s appended joint tensor, and each single-stream block output as a graph cut. |
Priority:
Estimated code review effort: 2 (Simple) | ~8 minutes
Change: Bug fix · Severity of issue fixed: Medium
Suggested reviewers: noctrex
Merge Risk: 
Minimal · up to f388e
-
No concrete merge-blocking issue was found in the graph-cut changes.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Linked Issues check
-
Explanation
Issue
#2219requires graph cuts for FLUX.3 segmented execution. The diff adds cuts after each non-final mode block, after each mode is appended tojoint, and after every single block. These changes match the issue's proposed boundaries and target the Q8_0 offload failure. Issue-reported runtime results are not independently verified, but the required code change is present. The issue does not specify an automated test requirement.
-
-
Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Summary
Related Issue / Discussion
Fixes #2219.
Additional Information
N/A
Checklist
Summary by CodeRabbit