Prepare Windows PATH and agent skills during MAX npm installation - #386
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Global npm installation previously created max’s launcher without ensuring Windows could find it or installing agent instructions. Add the same global-install completion flow as Telegram: preserve Windows user PATH, keep the working .cmd launcher, install the versioned skill before login and tell an already-running agent to refresh its shell.
Project dependencies and npx remain side-effect free. MAX_INSTALL_AGENT selects/opts out of skills; the shared installer’s TG_INSTALL_AGENT remains compatible. Ship exact installer entrypoints and document recovery when npm skips lifecycle scripts. No account operations or version bump.
Validation: lint, type checking, docs/spelling/Markdown checks, 1368 unit tests (two existing skips), generated docs/test matrix, Bun smoke and a real packed global npm installation into an isolated Linux home/prefix. New Windows CI installs that tarball under Node 22.16/24, checks registry preservation, a restricted shell, skill files, repeated repair, disabled scripts and PowerShell 5.1.