Repository navigation
fix(docs): commands that change only this computer get their own label - #211
Merged
Merged
Conversation
config set|unset, chats rules set|unset, recipients add|remove|clear and the bot's auth set|remove and recipients add|remove|clear said "Changes something in Telegram." They write local files and the keyring. With cli-messaging 0.98.0 marking them `local` and cli-core 0.15.0, the page says "Changes something on this computer only." docs/security.md names them. 0.98.0 also brings bot chats admins add and members remove --block, which tg's bot cannot do yet, and bot messages list --limit; a test covers each, so the test matrix stays complete. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
docs/commands.mdsaid "Changes something in Telegram." under commands that change only local files, anddocs/security.mdrelies on that label to say what changes Telegram.What
overridestoo) and cli-messaging 0.98.0, which marks 12 commandslocal(fix(cli): mark commands that change only this computer as local writes cli-messaging#360).scripts/commands.tspassesmutatesLocal: "Changes something on this computer only." Now onconfig set|unset,chats rules set|unset,recipients add|remove|clear,bot auth set|remove,bot recipients add|remove|clear.chats moderate,session endand every other Telegram write keep the Telegram line.tg commands --jsonstill marks all 12mutates(writes: yes).docs/security.md: the sentence onmutatesnames these local writes.bot chats admins addandmembers remove --block(tg's bot adapter cannot do them yet; a test checks it refuses before calling Telegram) andbot messages list --limit(tested).Decision: a second mark (
local) rather than droppingmutates, because agents readwritesto tell reads from writes.Testing
pnpm lint && pnpm typecheck && pnpm test && pnpm docs:check && pnpm parity:checkpass;pnpm release:checkfails only on the version and the changelog date.🤖 Generated with Claude Code