Fix color palette for PaperColor themes#44
Open
ThomasLamprecht wants to merge 1 commit intolemnos:masterfrom
Open
Fix color palette for PaperColor themes#44ThomasLamprecht wants to merge 1 commit intolemnos:masterfrom
ThomasLamprecht wants to merge 1 commit intolemnos:masterfrom
Conversation
Ensure that the palette follows the original, upstream definition[0], as the previous defined ones were quite a bit off. While the colors used are in the PaperColor palette, their place in the palette definition was wrong/scrambled. I compared the now fixed ones with the VIM variant, which the original PaperColor project defines itself, by simply opening a plain text file there and using `cat` on the same file in another shell, quickly switching between them to ensure both are rendered the same. Additionally, I compared the adapted palette here with the PaperColor theme of the foot editor, looks good now. 0: https://github.com/NLKNguyen/papercolor-theme#-colors Signed-off-by: Thomas Lamprecht <thomas@lamprecht.org>
Author
|
Just checked in on this PR and noticed that the posted screenshots aren't really ideal to show of what/that it's fixed. So I've redone them with a short shell oneliner to print out the standard palette: That is much more easily compared with the "Light" column of the original color palette definition: Original:After applying this PR: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Ensure that the palette follows the original, upstream definition [0], as the previous defined ones were quite a bit off. While the colors used are in the PaperColor palette, their place in the palette definition was wrong/scrambled.
I compared the now fixed ones with the VIM variant, which the original PaperColor project defines itself, by simply opening a plain text file there and using
caton the same file in another shell, quickly switching between them to ensure both are rendered the same.Additionally, I compared the adapted palette here with the PaperColor theme of the foot editor, looks good now.
0: https://github.com/NLKNguyen/papercolor-theme#-colors
E.g., a simple comparison of the papercolor-dark variant:
Previously, with wrong palette:

With this commit and the now original PaperColor palette:
